Review Request 129765: Handle the case of an enum with visibility attributes.

[Stephen Kelly]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129765/#review101825
-----------------------------------------------------------


Ship it!




Perfect, thanks! I've cherry-picked (not merged) this and pushed it to master.

- Stephen Kelly


On Jan. 5, 2017, 8:31 a.m., Shaheed Haque wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129765/
> -----------------------------------------------------------
> 
> (Updated Jan. 5, 2017, 8:31 a.m.)
> 
> 
> Review request for Extra Cmake Modules.
> 
> 
> Repository: extra-cmake-modules
> 
> 
> Description
> -------
> 
> The problem can be seen in the wild in, for example,
> KActivitiesStats/kactivitiesstats/cleaning.h
> 
> 
> Diffs
> -----
> 
>   find-modules/sip_generator.py 10be147711540437d38153fa8fe859bd34d7aa6c 
>   tests/GenerateSipBindings/cpplib.h 0d63c30ed52b5d817c233e358b1ebce7a70c8218 
>   tests/GenerateSipBindings/testscript.py 6f2132a2282208d914c0d5685fc78cf69e747b5e 
> 
> Diff: https://git.reviewboard.kde.org/r/129765/diff/
> 
> 
> Testing
> -------
> 
> $ make test
> Running tests...
> Test project /home/.../extra-cmake-modules
>       Start  1: GenerateSipBindings
>  1/49 Test  #1: GenerateSipBindings ...................................   Passed    8.59 sec
>       Start  2: ExecuteCoreModules
>  2/49 Test  #2: ExecuteCoreModules ....................................   Passed    0.46 sec
>       Start  3: ExecuteKDEModules
> 
> 
> Thanks,
> 
> Shaheed Haque
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-buildsystem/attachments/20170105/22f48519/attachment.html>