<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/129765/">https://git.reviewboard.kde.org/r/129765/</a>
</td>
</tr>
</table>
<br />
<p>
Ship it!
</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Perfect, thanks! I've cherry-picked (not merged) this and pushed it to master.</p></pre>
<br />
<p>- Stephen Kelly</p>
<br />
<p>On January 5th, 2017, 8:31 a.m. UTC, Shaheed Haque wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Extra Cmake Modules.</div>
<div>By Shaheed Haque.</div>
<p style="color: grey;"><i>Updated Jan. 5, 2017, 8:31 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
extra-cmake-modules
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The problem can be seen in the wild in, for example,
KActivitiesStats/kactivitiesstats/cleaning.h</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">$ make test
Running tests...
Test project /home/.../extra-cmake-modules
Start 1: GenerateSipBindings
1/49 Test #1: GenerateSipBindings ................................... Passed 8.59 sec
Start 2: ExecuteCoreModules
2/49 Test #2: ExecuteCoreModules .................................... Passed 0.46 sec
Start 3: ExecuteKDEModules</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>find-modules/sip_generator.py <span style="color: grey">(10be147711540437d38153fa8fe859bd34d7aa6c)</span></li>
<li>tests/GenerateSipBindings/cpplib.h <span style="color: grey">(0d63c30ed52b5d817c233e358b1ebce7a70c8218)</span></li>
<li>tests/GenerateSipBindings/testscript.py <span style="color: grey">(6f2132a2282208d914c0d5685fc78cf69e747b5e)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/129765/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>