[Differential] [Commented On] D4509: Python bindings: Some comment-only tidyups and PEP-8 fixes.
Shaheed Haque
noreply at phabricator.kde.org
Sun Feb 12 20:49:47 UTC 2017
shaheed added inline comments.
INLINE COMMENTS
> skelly wrote in rules_engine.py:58
> I don't think this should be here.
I disagree. Having this in the code suppresses the false positives which are caused by the "_" used by gettext.
> skelly wrote in rules_engine.py:704
> I don't think the comments are valuable.
I think they are perfectly reasonable.
REPOSITORY
R240 Extra CMake Modules
REVISION DETAIL
https://phabricator.kde.org/D4509
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: shaheed, #build_system, #frameworks, skelly
Cc: #frameworks, #build_system
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-buildsystem/attachments/20170212/603bc7a2/attachment.html>
More information about the Kde-buildsystem
mailing list