[Differential] [Commented On] D4509: Python bindings: Some comment-only tidyups and PEP-8 fixes.
Stephen Kelly
noreply at phabricator.kde.org
Sun Feb 12 20:45:19 UTC 2017
skelly added a comment.
In https://phabricator.kde.org/D4509#85725, @shaheed wrote:
> The PEP-8 changes are some blank line changes.
There is exactly one blank line insertion, and it makes this TypedefRuleDb documentation inconsistent with, say, the VariableRuleDb, which doesn't have blank lines in the same spot. Should it? If yes, then please just create a commit which adds the blank lines where the blank lines should be and does not do anything else. That would be a commit which is easily and quickly reviewable. I've said this a few times but it seems to be something you are still not doing.
REPOSITORY
R240 Extra CMake Modules
REVISION DETAIL
https://phabricator.kde.org/D4509
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: shaheed, #build_system, #frameworks, skelly
Cc: #frameworks, #build_system
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-buildsystem/attachments/20170212/0e69d16c/attachment.html>
More information about the Kde-buildsystem
mailing list