Review Request 128278: Re-use tar macro from kdevplatform. To fix dependent builds reproducibility.

[Maximiliano Curia]

> On Feb. 4, 2017, 7:14 p.m., Albert Astals Cid wrote:
> > Any reason we ignore .svn and not .git?
> 
> Maximiliano Curia wrote:
>     This file, and this patch, comes from the kapptemplate repo, and apparently when copied to extra-cmake-module it dropped a couple of parts like the kdev_ignore and .svn exclude and the the DEPENDS ${_deps} in the add_custom_command.
>     
>     Also, this module seems to predate git repositories, or it hasn't yet been used in a git with submodules.
> 
> Scarlett Clark wrote:
>     Umm nope, looking at my diff above, those were not at all dropped.

The current file in extra-cmake-modules has a "deadcode" block (that sets _deps, which is not used), the old file in kapptemplates used the _deps in the DEPENDS ${_deps} parameter to the add_custom_command macro.

Also the current file in extra-cmake-modules is not excluding kdev_ignore .svn, as was done in kapptemplate.

Your patch partially re adds this.


- Maximiliano


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128278/#review102385
-----------------------------------------------------------


On Feb. 9, 2017, 2:18 p.m., Scarlett Clark wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128278/
> -----------------------------------------------------------
> 
> (Updated Feb. 9, 2017, 2:18 p.m.)
> 
> 
> Review request for Extra Cmake Modules, Sune Vuorela and Simon Wächter.
> 
> 
> Repository: extra-cmake-modules
> 
> 
> Description
> -------
> 
> Cmake tar command does not allow for switches that fix umask and user/group inconsistancy which cause unreproducible builds. This patch takes the tar command used in kdevplatform that has all the required switches to make builds that use this macro reproducible.
> 
> 
> Diffs
> -----
> 
>   kde-modules/KDEPackageAppTemplates.cmake c0eb8b9 
> 
> Diff: https://git.reviewboard.kde.org/r/128278/diff/
> 
> 
> Testing
> -------
> 
> Build and installed ECM and then rebuilt an affected project ( plasma-framework ) which is now reproducible.
> 
> 
> Thanks,
> 
> Scarlett Clark
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-buildsystem/attachments/20170209/cf44fe9f/attachment-0001.html>