Review Request 128231: Set slightly more unique header guard for logging categories

David Edmundson david at davidedmundson.co.uk
Wed Feb 8 15:36:26 UTC 2017


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128231/
-----------------------------------------------------------

(Updated Feb. 8, 2017, 3:36 p.m.)


Status
------

This change has been discarded.


Review request for Extra Cmake Modules.


Repository: extra-cmake-modules


Description
-------

The default generated guard is based on <category_name>_H . It's not
unreasnoble to have another header file in the same project with the
same name as the category name and thus same guard name.


Diffs
-----

  modules/ECMQtDeclareLoggingCategory.cmake c125949a46c4b83544413f23d5e04b2d8ea2c4cf 

Diff: https://git.reviewboard.kde.org/r/128231/diff/


Testing
-------


Thanks,

David Edmundson

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-buildsystem/attachments/20170208/051cd6d3/attachment.html>


More information about the Kde-buildsystem mailing list