D9118: ki18n cmake macros: Mark UIC-generated .h files to skip AUTOMOC by default

Kevin Funk noreply at phabricator.kde.org
Mon Dec 4 08:59:34 UTC 2017


kfunk accepted this revision.
kfunk added a comment.
This revision is now accepted and ready to land.


  This shouldn't create any troubles with earlier CMake versions.
  
  Also note that we set the same properties unconditionally in newer Qt5 CMake macros: https://codereview.qt-project.org/#/c/207327

INLINE COMMENTS

> KF5I18NMacros.cmake:56
>        )
> +      set_property(SOURCE ${_header} PROPERTY SKIP_AUTOMOC ON)
>        list(APPEND ${_sources} ${_header})

`set_source_files_properties(${_header} ...)` is probably the more canonical way to do this.

REPOSITORY
  R249 KI18n

REVISION DETAIL
  https://phabricator.kde.org/D9118

To: mpyne, #frameworks, #build_system, #localization, kfunk
Cc: aacid
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-buildsystem/attachments/20171204/39cdde67/attachment.html>


More information about the Kde-buildsystem mailing list