D9118: ki18n cmake macros: Mark UIC-generated .h files to skip AUTOMOC by default

Michael Pyne noreply at phabricator.kde.org
Sun Dec 3 15:53:19 UTC 2017


mpyne added a comment.


  In https://phabricator.kde.org/D9118#174892, @aacid wrote:
  
  > Will this cause trouble with older cmake versions?
  
  
  Good question, I haven't tried it. I've verified that `set_property` at least is present in 2.8.12 <https://cmake.org/cmake/help/v2.8.8/cmake.html#command:set_property> so it shouldn't introduce a syntax error.  Whether the added semantic of turning on SKIP_AUTOMOC introduces an issue is open.
  
  Perhaps it's best to try to wrap with a version check.  If no one is able to test on an ancient supported CMake I can try to adapt the patch to add that.

REPOSITORY
  R249 KI18n

REVISION DETAIL
  https://phabricator.kde.org/D9118

To: mpyne, #frameworks, #build_system, #localization, kfunk
Cc: aacid
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-buildsystem/attachments/20171203/005a04b2/attachment.html>


More information about the Kde-buildsystem mailing list