Review Request 129117: Adds KF5Purpose and Kirigami to the default build

[Michael Pyne]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129117/#review100026
-----------------------------------------------------------



I think at some point I will want to find a way to have the kf5-*-build-include files be a reduced set of modules nearly everyone agrees are essential, and then have a user's own desired module-sets be picked up based on a separate file, that way we don't have to add every KF5 and Plasma5 module into the sample KF5-based configuration. But that's neither here nor there...

The changes make sense but I would recommend some differences.

I think it would be better to have the repos that are currently in extragear or playground (but eventually destined for KF5) to be factored out into their own separate module-set. Once they enter KF5 they should be removed from kf5-frameworks-build-include since kdesrc-build will find them automatically, but if every such module is spread across multiple kf5-*-build-include files it will make that cleanup that much harder.

The kamoso comment below is similar -- if we rely on manually adding repo names to kf5-*-build-include then many users will simply never build or test these repos.


kf5-applications-build-include (line 26)
<https://git.reviewboard.kde.org/r/129117/#comment67200>

    If the idea is to build everything in kdegraphics then it is probably better to replace all of these sub-modules with something like `use-modules kde/kdegraphics`.
    
    The `kde/` is itself redundant and unnecessary, that's just an effort to make it clear it's not simply a single repository name.


- Michael Pyne


On Oct. 10, 2016, 10:07 a.m., Tomaz  Canabrava wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129117/
> -----------------------------------------------------------
> 
> (Updated Oct. 10, 2016, 10:07 a.m.)
> 
> 
> Review request for Build System.
> 
> 
> Repository: kdesrc-build
> 
> 
> Description
> -------
> 
> Kirigami is now needed to run discover, so it should be build
> Purpose is needed by at least kamoso.
> 
> Signed-off-by: Tomaz Canabrava <tcanabrava at kde.org>
> 
> Add Kamoso to the buildsystem.
> 
> Kamoso was missing from kdegraphics.
> 
> Signed-off-by: Tomaz Canabrava <tcanabrava at kde.org>
> 
> 
> Diffs
> -----
> 
>   kf5-applications-build-include f53c0233ba46322829076db3437cf9c62a65ff8e 
>   kf5-frameworks-build-include a88498e3248262d2e1fddacd726e1ef06a3ac1e4 
> 
> Diff: https://git.reviewboard.kde.org/r/129117/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Tomaz  Canabrava
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-buildsystem/attachments/20161015/28e5683c/attachment.html>