<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/129117/">https://git.reviewboard.kde.org/r/129117/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I think at some point I will want to find a way to have the kf5-*-build-include files be a reduced set of modules nearly everyone agrees are essential, and then have a user's own desired module-sets be picked up based on a separate file, that way we don't have to add every KF5 and Plasma5 module into the sample KF5-based configuration. But that's neither here nor there...
The changes make sense but I would recommend some differences.
I think it would be better to have the repos that are currently in extragear or playground (but eventually destined for KF5) to be factored out into their own separate module-set. Once they enter KF5 they should be removed from kf5-frameworks-build-include since kdesrc-build will find them automatically, but if every such module is spread across multiple kf5-*-build-include files it will make that cleanup that much harder.
The kamoso comment below is similar -- if we rely on manually adding repo names to kf5-*-build-include then many users will simply never build or test these repos.</pre>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/129117/diff/1/?file=481793#file481793line26" style="color: black; font-weight: bold; text-decoration: underline;">kf5-applications-build-include</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">26</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> use-modules libkipi kipi-plugins gwenview okular spectacle kolourpaint libkcddb</pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">26</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> use-modules libkipi kipi-plugins gwenview okular spectacle kolourpaint libkcddb<span class="hl"> kamoso</span></pre></td>
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">If the idea is to build everything in kdegraphics then it is probably better to replace all of these sub-modules with something like `use-modules kde/kdegraphics`.
The `kde/` is itself redundant and unnecessary, that's just an effort to make it clear it's not simply a single repository name.</pre>
</div>
</div>
<br />
<p>- Michael Pyne</p>
<br />
<p>On October 10th, 2016, 10:07 a.m. UTC, Tomaz Canabrava wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Build System.</div>
<div>By Tomaz Canabrava.</div>
<p style="color: grey;"><i>Updated Oct. 10, 2016, 10:07 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdesrc-build
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Kirigami is now needed to run discover, so it should be build
Purpose is needed by at least kamoso.
Signed-off-by: Tomaz Canabrava <tcanabrava@kde.org>
Add Kamoso to the buildsystem.
Kamoso was missing from kdegraphics.
Signed-off-by: Tomaz Canabrava <tcanabrava@kde.org></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kf5-applications-build-include <span style="color: grey">(f53c0233ba46322829076db3437cf9c62a65ff8e)</span></li>
<li>kf5-frameworks-build-include <span style="color: grey">(a88498e3248262d2e1fddacd726e1ef06a3ac1e4)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/129117/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>