Review Request 129552: Fix dbus-activation on Windows
Albert Vaca Cintora
albertvaka at gmail.com
Thu Nov 24 13:50:52 UTC 2016
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129552/
-----------------------------------------------------------
(Updated Nov. 24, 2016, 2:50 p.m.)
Review request for Extra Cmake Modules, kdewin, David Faure, and Hannah von Reth.
Summary (updated)
-----------------
Fix dbus-activation on Windows
Repository: extra-cmake-modules
Description
-------
For dbus-activation to work, .service files have to be installed in /share/dbus-1/services, as there's where dbus-daemon looks for them.
Our approach of installing everything in /bin/data under Windows works for Qt, but not for other libs and daemons, which still look for stuff in /share.
An alternative solution would be to patch dbus-daemon and everything else, but I think this is cleaner than having to maintain an increasing number of patches for external projects.
Diffs
-----
kde-modules/KDEInstallDirs.cmake 7f5e44778b85906d3a619d0ce2c15cd0ead0eaac
Diff: https://git.reviewboard.kde.org/r/129552/diff/
Testing (updated)
-------
DBus now finds KDE Connect service file, the daemon starts upon demand.
Thanks,
Albert Vaca Cintora
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-buildsystem/attachments/20161124/bbfc325e/attachment.html>
More information about the Kde-buildsystem
mailing list