Review Request 128112: New module: ecm_win_resolve_symlinks

Gleb Popov 6yearold at gmail.com
Fri Jun 17 08:32:58 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128112/
-----------------------------------------------------------

(Updated June 17, 2016, 11:32 a.m.)


Review request for Extra Cmake Modules.


Changes
-------

Address comments.


Repository: extra-cmake-modules


Description
-------

When git is checking out repositories with UNIX symbolic links inside on Windows machine, it writes them as plain text files, containing relative path to the real file. This is the case for breeze-icons framework, for instance, and this breaks some icons that are symlinked.

This macro is intended to fix that. There is some room for performance improvement, but i wanted to get the feedback early.


Diffs (updated)
-----

  modules/ECMWinResolveSymlinks.cmake PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/128112/diff/


Testing
-------


Thanks,

Gleb Popov

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-buildsystem/attachments/20160617/1be9b5a1/attachment.html>


More information about the Kde-buildsystem mailing list