Review Request 127169: By default, make KDE_INSTALL_USE_QT_SYS_PATHS share the same directory scheme as Qt if they share the prefix

Hrvoje Senjan hrvoje.senjan at gmail.com
Wed Jun 8 15:49:42 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127169/#review96298
-----------------------------------------------------------




kde-modules/KDEInstallDirs.cmake (line 431)
<https://git.reviewboard.kde.org/r/127169/#comment65096>

    FWIW, this defacto makes Qt5Core required for anyone that doesn't explicitly disables KDE_INSTALL_USE_QT_SYS_PATHS.
    
    E.g. labplot uses ECM and Qt4.


- Hrvoje Senjan


On April 7, 2016, 1:08 a.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127169/
> -----------------------------------------------------------
> 
> (Updated April 7, 2016, 1:08 a.m.)
> 
> 
> Review request for Extra Cmake Modules, KDE Frameworks and Albert Vaca Cintora.
> 
> 
> Repository: extra-cmake-modules
> 
> 
> Description
> -------
> 
> Make Qt and ECM-based projects use the same directory sctructure (i.e. where plugins are, libs, etc.) by default. Otherwise it creates a tiny mess that might be controlled but usually won't.
> 
> In the end, otherwise, people need to keep adapting their systems with environment variables anyway. All distros end up setting always this setting as ON, as well as brave developers who don't have separate prefixes for Qt and KDE.
> 
> 
> Diffs
> -----
> 
>   kde-modules/KDEInstallDirs.cmake ebd48fa 
> 
> Diff: https://git.reviewboard.kde.org/r/127169/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-buildsystem/attachments/20160608/1c68d9f7/attachment.html>


More information about the Kde-buildsystem mailing list