Review Request 126303: ECMAddAppIconMacro: Add OUTFILE parameter

[Alex Merry]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126303/#review91347
-----------------------------------------------------------




modules/ECMAddAppIcon.cmake (lines 24 - 27)
<https://git.reviewboard.kde.org/r/126303/#comment62451>

    Can we have a different parameter name, please? If I see OUTFILE, I expect it to be the actual file name (probably a full path), not a basename. OUTFILE_BASE would work, but I'm open to suggestions.


- Alex Merry


On Jan. 19, 2016, 9:30 a.m., Dominik Schmidt wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126303/
> -----------------------------------------------------------
> 
> (Updated Jan. 19, 2016, 9:30 a.m.)
> 
> 
> Review request for Extra Cmake Modules.
> 
> 
> Repository: extra-cmake-modules
> 
> 
> Description
> -------
> 
> On OSX I want to ship "Tomahawk.icns" instead of "tomahawkSources.icns" which is the autogenerated name for our sources variable, thus I added an optional paramater allowing to override the basename (without extension).
> 
> 
> Diffs
> -----
> 
>   modules/ECMAddAppIcon.cmake f90d4c3 
> 
> Diff: https://git.reviewboard.kde.org/r/126303/diff/
> 
> 
> Testing
> -------
> 
> Tested it in Tomahawk and it works.
> 
> edit1: Actually, something is fishy. Still investigating.
> edit2: Nope, everything's fine. Random CMake fnord, hadn't tried a clean build.
> 
> 
> Thanks,
> 
> Dominik Schmidt
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-buildsystem/attachments/20160119/47c5039b/attachment.html>