Review Request 126303: ECMAddAppIconMacro: Add OUTFILE parameter
Dominik Schmidt
kde at dominik-schmidt.de
Tue Jan 19 09:30:13 UTC 2016
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126303/
-----------------------------------------------------------
(Updated Jan. 19, 2016, 9:30 a.m.)
Review request for Extra Cmake Modules.
Changes
-------
Added documentation
Repository: extra-cmake-modules
Description
-------
On OSX I want to ship "Tomahawk.icns" instead of "tomahawkSources.icns" which is the autogenerated name for our sources variable, thus I added an optional paramater allowing to override the basename (without extension).
Diffs (updated)
-----
modules/ECMAddAppIcon.cmake f90d4c3
Diff: https://git.reviewboard.kde.org/r/126303/diff/
Testing
-------
Tested it in Tomahawk and it works.
edit1: Actually, something is fishy. Still investigating.
edit2: Nope, everything's fine. Random CMake fnord, hadn't tried a clean build.
Thanks,
Dominik Schmidt
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-buildsystem/attachments/20160119/cbc6a2a6/attachment.html>
More information about the Kde-buildsystem
mailing list