Review Request 126711: ECMAddAppIcon: Use absolute path when operating on icons

[Gleb Popov]

> On Jan. 11, 2016, 12:09 a.m., Kevin Funk wrote:
> > modules/ECMAddAppIcon.cmake, line 90
> > <https://git.reviewboard.kde.org/r/126711/diff/1/?file=430315#file430315line90>
> >
> >     Arguable if you need to change this...
> >     
> >     But indeed, just matching the name is the safer approach.

ECMInstallIcons does exactly this when matching name.


- Gleb


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126711/#review90849
-----------------------------------------------------------


On Jan. 10, 2016, 11 p.m., Gleb Popov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126711/
> -----------------------------------------------------------
> 
> (Updated Jan. 10, 2016, 11 p.m.)
> 
> 
> Review request for Extra Cmake Modules and Kevin Funk.
> 
> 
> Repository: extra-cmake-modules
> 
> 
> Description
> -------
> 
> This makes it optional to list icons with ${CMAKE_CURRENT_SOURCE_DIR}/ prefix.
> 
> 
> Diffs
> -----
> 
>   modules/ECMAddAppIcon.cmake 5233a5f 
> 
> Diff: https://git.reviewboard.kde.org/r/126711/diff/
> 
> 
> Testing
> -------
> 
> Built KDevelop on Windows, the icon is here.
> 
> 
> Thanks,
> 
> Gleb Popov
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-buildsystem/attachments/20160111/294a8399/attachment.html>