Review Request 126711: ECMAddAppIcon: Use absolute path when operating on icons

[Kevin Funk]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126711/#review90849
-----------------------------------------------------------

Ship it!


LGTM.

Please wait for another +1.


modules/ECMAddAppIcon.cmake (line 90)
<https://git.reviewboard.kde.org/r/126711/#comment62077>

    Arguable if you need to change this...
    
    But indeed, just matching the name is the safer approach.


- Kevin Funk


On Jan. 10, 2016, 8 p.m., Gleb Popov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126711/
> -----------------------------------------------------------
> 
> (Updated Jan. 10, 2016, 8 p.m.)
> 
> 
> Review request for Extra Cmake Modules and Kevin Funk.
> 
> 
> Repository: extra-cmake-modules
> 
> 
> Description
> -------
> 
> This makes it optional to list icons with ${CMAKE_CURRENT_SOURCE_DIR}/ prefix.
> 
> 
> Diffs
> -----
> 
>   modules/ECMAddAppIcon.cmake 5233a5f 
> 
> Diff: https://git.reviewboard.kde.org/r/126711/diff/
> 
> 
> Testing
> -------
> 
> Built KDevelop on Windows, the icon is here.
> 
> 
> Thanks,
> 
> Gleb Popov
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-buildsystem/attachments/20160110/e2c13158/attachment.html>