Review Request 129117: Adds KF5Purpose and Kirigami to the default build

[Michael Pyne]

On Mon, Dec 05, 2016 at 12:40:21PM +0100, Tomaz Canabrava wrote:
> On Mon, Dec 5, 2016 at 9:00 AM, Ben Cooksley <bcooksley at kde.org> wrote:
> 
> > This is an automatically generated e-mail. To reply, visit:
> > https://git.reviewboard.kde.org/r/129117/
> >
> > On December 3rd, 2016, 11:36 p.m. UTC, *David Faure* wrote:
> >
> > I withdraw my approval. Please revert.
> >
> > I'm with David here. Libraries should also stop abusing KF5* - that prefix is exclusively reserved for Frameworks.
> >
> >
> I'll revert, but this thread raised concerns that are way way beyond my
> patch, what I wanted with this was just to be able to compile some KDE
> software that whas missing, moving an application / library out of
> playground (that I don't even commited a single line of code) seems to be
> way out of scope for this change.

This was part of what I'd been concerned with, but after reading my
initial review I see that I never actually mentioned that except with an
aside about eventually having the relevant git repos move under frameworks/*

> now, kamoso depends om something that's in playground, not easily
> reversible, and I wanna have kamoso on my system (I actually use that),
> should I message the kamoso developers to move purpose out of playground?

That's a good first step, and if it leads to the kamoso devs
occasionally packging purpose that would help our packagers (and
therefore many other users) as well.

However you can also manually include purpose within your local
kdesrc-build configuration so that it's updated and built when you'd
otherwise be building kamoso.

There's various options for doing this.  I'd recommend a shell
kdesrc-buildrc file that uses the "include" declaration to pull in
applicable kf5-*-build-include files from the kdesrc-build git
repository.  See kf5-qt5-build-include for an example.

Regards,
 - Michael Pyne