Review Request 128714: Kexi needs breeze-icons as a binary resource.

David Faure faure at kde.org
Wed Aug 24 10:41:00 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128714/#review98586
-----------------------------------------------------------




kf5-frameworks-build-include (line 76)
<https://git.reviewboard.kde.org/r/128714/#comment66410>

    The module breeze-icons is already defined here, no need to define it again. Please just use 
    
    options breeze-icons
       cmake-options ...
    end options


- David Faure


On Aug. 19, 2016, 2:02 p.m., Tomaz  Canabrava wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128714/
> -----------------------------------------------------------
> 
> (Updated Aug. 19, 2016, 2:02 p.m.)
> 
> 
> Review request for Build System.
> 
> 
> Repository: kdesrc-build
> 
> 
> Description
> -------
> 
> This patch fixes the configuration step of kexi, that
> needs breeze-icons, but as a binary resource.
> 
> Signed-off-by: Tomaz Canabrava <tomaz.canabrava at gmail.com>
> 
> 
> Diffs
> -----
> 
>   kf5-frameworks-build-include e684b0def9bb93370c82365e6c42827bb7297e69 
> 
> Diff: https://git.reviewboard.kde.org/r/128714/diff/
> 
> 
> Testing
> -------
> 
> Compiled kexi, that used to fail. now it compiles.
> 
> 
> Thanks,
> 
> Tomaz  Canabrava
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-buildsystem/attachments/20160824/a7125198/attachment.html>


More information about the Kde-buildsystem mailing list