Review Request 127701: Android deployment: Deprecate ANDROID_NDK in favour of ANDROID_NDK_ROOT

[Friedrich W. H. Kossebau]

> On April 20, 2016, 10:03 p.m., Aleix Pol Gonzalez wrote:
> > toolchain/Android.cmake, line 93
> > <https://git.reviewboard.kde.org/r/127701/diff/1/?file=456348#file456348line93>
> >
> >     it says `..._NNDK_...`.

Sorry, forgot to save again before creating the patch (that one was left-over from testing). Fixed locally.


> On April 20, 2016, 10:03 p.m., Aleix Pol Gonzalez wrote:
> > toolchain/Android.cmake, line 103
> > <https://git.reviewboard.kde.org/r/127701/diff/1/?file=456348#file456348line103>
> >
> >     Syntax is wrong here? `${_ENV_ANDROID_NDK_ROOT}` looks odd.

Syntax should be correct. But maybe the logic is not yet obvious or broken :) So, this is how I intended it:
In the section "handle deprecated env vars" first the official env var is pulled. if not existing (or having a proper value, perhaps to gentle here?) then the deprecated env var is pulled (and at the time also a warning emitted).
Whatever value is taken from that section has been stored away in the cmake var _ENV_ANDROID_NDK_ROOT, which then is used as normal in the "input" section (just not fetched there any longer).

So as this seems not straight to get for everyone, how would you do this logic?


- Friedrich W. H.


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127701/#review94739
-----------------------------------------------------------


On April 20, 2016, 8:05 p.m., Friedrich W. H. Kossebau wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127701/
> -----------------------------------------------------------
> 
> (Updated April 20, 2016, 8:05 p.m.)
> 
> 
> Review request for Extra Cmake Modules and Aleix Pol Gonzalez.
> 
> 
> Repository: extra-cmake-modules
> 
> 
> Description
> -------
> 
> See https://mail.kde.org/pipermail/kde-android/2016-April/000048.html for motivation.
> 
> The old-env-var-deprecated warning is shown quite often, possibly because the toolchain file is run with every initial initial check? Any proposal how to make that warning only shown once?
> 
> 
> Diffs
> -----
> 
>   toolchain/Android.cmake 60bd058 
> 
> Diff: https://git.reviewboard.kde.org/r/127701/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Friedrich W. H. Kossebau
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-buildsystem/attachments/20160420/8949a382/attachment.html>