Review Request 127701: Android deployment: Deprecate ANDROID_NDK in favour of ANDROID_NDK_ROOT

[Aleix Pol Gonzalez]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127701/#review94739
-----------------------------------------------------------




toolchain/Android.cmake (line 93)
<https://git.reviewboard.kde.org/r/127701/#comment64375>

    it says `..._NNDK_...`.



toolchain/Android.cmake (line 94)
<https://git.reviewboard.kde.org/r/127701/#comment64376>

    You could do: `if (DEFINED $ENV{...`



toolchain/Android.cmake (line 103)
<https://git.reviewboard.kde.org/r/127701/#comment64377>

    Syntax is wrong here? `${_ENV_ANDROID_NDK_ROOT}` looks odd.


- Aleix Pol Gonzalez


On April 20, 2016, 10:05 p.m., Friedrich W. H. Kossebau wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127701/
> -----------------------------------------------------------
> 
> (Updated April 20, 2016, 10:05 p.m.)
> 
> 
> Review request for Extra Cmake Modules and Aleix Pol Gonzalez.
> 
> 
> Repository: extra-cmake-modules
> 
> 
> Description
> -------
> 
> See https://mail.kde.org/pipermail/kde-android/2016-April/000048.html for motivation.
> 
> The old-env-var-deprecated warning is shown quite often, possibly because the toolchain file is run with every initial initial check? Any proposal how to make that warning only shown once?
> 
> 
> Diffs
> -----
> 
>   toolchain/Android.cmake 60bd058 
> 
> Diff: https://git.reviewboard.kde.org/r/127701/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Friedrich W. H. Kossebau
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-buildsystem/attachments/20160420/c69bd5f6/attachment-0001.html>