Review Request 125163: Disable X11,XCB etc. detection on OS X

[Alex Merry]

> On Sept. 14, 2015, 6:43 p.m., Alex Merry wrote:
> > OK, consensus seems to be overwhelmingly positive. There's a month before the next release, so we can revisit the default setting if something comes up in the next few weeks, but I'm happy to have it in in the meantime.
> 
> Samuel Gaist wrote:
>     Shouldn't I add the warning message before shiping it ?

Sure, that's probably a good idea. Maybe have some way to disable the warning, though (ie: the warning should be printed if neither ``APPLE_FORCE_X11`` nor ``APPLE_SUPPRESS_X11_WARNING`` is set). The warning should be reasonably brief, but document both options, like

    message(WARNING "Searching for X11 and related technologies is disabled on Apple systems. Set APPLE_FORCE_X11 to ON to change this behaviour. Set APPLE_SUPPRESS_X11_WARNING to ON to hide this warning.")


- Alex


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125163/#review85398
-----------------------------------------------------------


On Sept. 12, 2015, 9:19 p.m., Samuel Gaist wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125163/
> -----------------------------------------------------------
> 
> (Updated Sept. 12, 2015, 9:19 p.m.)
> 
> 
> Review request for Extra Cmake Modules.
> 
> 
> Repository: extra-cmake-modules
> 
> 
> Description
> -------
> 
> Disable X11,XCB etc. detection on OS X
> 
> 
> Diffs
> -----
> 
>   kde-modules/KDECMakeSettings.cmake 0c997931abee8673ccecc66d122108c6f72bf9b1 
> 
> Diff: https://git.reviewboard.kde.org/r/125163/diff/
> 
> 
> Testing
> -------
> 
> KCrash build on OS X 10.8
> 
> 
> Thanks,
> 
> Samuel Gaist
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-buildsystem/attachments/20150914/1148627e/attachment-0001.html>