Review Request 125163: Disable X11,XCB etc. detection on OS X

Samuel Gaist samuel.gaist at edeltech.ch
Mon Sep 14 19:56:32 UTC 2015



> On Sept. 14, 2015, 6:43 p.m., Alex Merry wrote:
> > OK, consensus seems to be overwhelmingly positive. There's a month before the next release, so we can revisit the default setting if something comes up in the next few weeks, but I'm happy to have it in in the meantime.

Shouldn't I add the warning message before shiping it ?


- Samuel


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125163/#review85398
-----------------------------------------------------------


On Sept. 12, 2015, 9:19 p.m., Samuel Gaist wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125163/
> -----------------------------------------------------------
> 
> (Updated Sept. 12, 2015, 9:19 p.m.)
> 
> 
> Review request for Extra Cmake Modules.
> 
> 
> Repository: extra-cmake-modules
> 
> 
> Description
> -------
> 
> Disable X11,XCB etc. detection on OS X
> 
> 
> Diffs
> -----
> 
>   kde-modules/KDECMakeSettings.cmake 0c997931abee8673ccecc66d122108c6f72bf9b1 
> 
> Diff: https://git.reviewboard.kde.org/r/125163/diff/
> 
> 
> Testing
> -------
> 
> KCrash build on OS X 10.8
> 
> 
> Thanks,
> 
> Samuel Gaist
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-buildsystem/attachments/20150914/23fa264f/attachment.html>


More information about the Kde-buildsystem mailing list