[cantor/Applications/14.12] /: Add cmake_minimum_required(VERSION 2.8.9) at the top and fix build.

[Alex Merry]

On Sunday 26 Jul 2015 09:57:23 Stephen Kelly wrote:
> David Faure wrote:
> > Git commit 19252f57cb5576a39e1a43cd19670d97e0cd9a8d by David Faure.
> > Committed on 25/07/2015 at 22:12.
> > Pushed by dfaure into branch 'Applications/14.12'.
> > 
> > Add cmake_minimum_required(VERSION 2.8.9) at the top and fix build.
> > 
> >  target_link_libraries( cantorlibs
> > 
> > + PUBLIC
> > 
> >    ${KDE4_KDECORE_LIBS}
> >    ${KDE4_KIO_LIBS}
> >    ${QT_LIBRARIES}
> 
> I guess you encountered some CMP0022 warnings and added PUBLIC.
> 
> You probably want LINK_PRIVATE instead, as you want the link implementation
> to not be propagated to callers (which was the case before you added
> PUBLIC), and because PRIVATE/PUBLIC were added with 2.8.12, but
> LINK_PRIVATE/LINK_PUBLIC are available with 2.8.9.

The CMake 2.8.8 documentation suggests the old behaviour was LINK_PUBLIC, not 
LINK_PRIVATE:

> Library dependencies are transitive by default. When this target is linked
> into another target then the libraries linked to this target will appear on
> the link line for the other target too. See the LINK_INTERFACE_LIBRARIES
> target property to override the set of transitive link dependencies for a
> target.

Alex