[cantor/Applications/14.12] /: Add cmake_minimum_required(VERSION 2.8.9) at the top and fix build.

[David Faure]

On Sunday 26 July 2015 09:57:23 Stephen Kelly wrote:
> David Faure wrote:
> 
> > Git commit 19252f57cb5576a39e1a43cd19670d97e0cd9a8d by David Faure.
> > Committed on 25/07/2015 at 22:12.
> > Pushed by dfaure into branch 'Applications/14.12'.
> > 
> > Add cmake_minimum_required(VERSION 2.8.9) at the top and fix build.
> > 
> 
> >  target_link_libraries( cantorlibs
> > + PUBLIC
> >    ${KDE4_KDECORE_LIBS}
> >    ${KDE4_KIO_LIBS}
> >    ${QT_LIBRARIES}
> 
> 
> I guess you encountered some CMP0022 warnings and added PUBLIC. 

Yup.

> You probably want LINK_PRIVATE instead, as you want the link implementation 
> to not be propagated to callers (which was the case before you added 
> PUBLIC), and because PRIVATE/PUBLIC were added with 2.8.12, but 
> LINK_PRIVATE/LINK_PUBLIC are available with 2.8.9. 
> 
>  http://quickgit.kde.org/?p=kdepimlibs.git&a=commitdiff&h=501d6986

I see. Thanks for the explanation. See why I shouldn't be the one fixing this :-)

-- 
David Faure, faure at kde.org, http://www.davidfaure.fr
Working on KDE Frameworks 5