Review Request 121545: Move the toolchain module to ECM

[Aleix Pol Gonzalez]

> On Jan. 10, 2015, 11:05 a.m., Alex Merry wrote:
> > toolchain/Android.cmake, lines 92-93
> > <https://git.reviewboard.kde.org/r/121545/diff/1/?file=333445#file333445line92>
> >
> >     This TODO looks like it should be resolved at this point.

Good catch. It's not needed anymore, it's provided by cmake (3.1).


> On Jan. 10, 2015, 11:05 a.m., Alex Merry wrote:
> > toolchain/Android.cmake, lines 123-124
> > <https://git.reviewboard.kde.org/r/121545/diff/1/?file=333445#file333445line123>
> >
> >     Why is this here, but commented out?

I'll remove it, it's just tests I did at some point in the past.


- Aleix


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121545/#review73657
-----------------------------------------------------------


On Dec. 16, 2014, 1:51 a.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121545/
> -----------------------------------------------------------
> 
> (Updated Dec. 16, 2014, 1:51 a.m.)
> 
> 
> Review request for Build System.
> 
> 
> Repository: extra-cmake-modules
> 
> 
> Description
> -------
> 
> I had this module for a while in a scratch repo, it was about time I moved it.
> It has been working quite well, I'm using it with Qt 5.4 and it's working fine. Also it requires cmake 3.1.
> 
> Today I just added the documentation so that it's easily usable by others, feedback appreciated.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 8356e2e 
>   toolchain/Android.cmake PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/121545/diff/
> 
> 
> Testing
> -------
> 
> I've built KAlgebra with this, as well as some other test applications.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-buildsystem/attachments/20150114/203e2f2c/attachment.html>