Review Request 121545: Move the toolchain module to ECM

Alex Merry alex.merry at kde.org
Sat Jan 10 11:05:15 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121545/#review73657
-----------------------------------------------------------


Can you please make the description include your intended commit message? It should include a CHANGELOG entry.


toolchain/Android.cmake
<https://git.reviewboard.kde.org/r/121545/#comment51265>

    This TODO looks like it should be resolved at this point.



toolchain/Android.cmake
<https://git.reviewboard.kde.org/r/121545/#comment51266>

    Why is this here, but commented out?


- Alex Merry


On Dec. 16, 2014, 1:51 a.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121545/
> -----------------------------------------------------------
> 
> (Updated Dec. 16, 2014, 1:51 a.m.)
> 
> 
> Review request for Build System.
> 
> 
> Repository: extra-cmake-modules
> 
> 
> Description
> -------
> 
> I had this module for a while in a scratch repo, it was about time I moved it.
> It has been working quite well, I'm using it with Qt 5.4 and it's working fine. Also it requires cmake 3.1.
> 
> Today I just added the documentation so that it's easily usable by others, feedback appreciated.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 8356e2e 
>   toolchain/Android.cmake PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/121545/diff/
> 
> 
> Testing
> -------
> 
> I've built KAlgebra with this, as well as some other test applications.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-buildsystem/attachments/20150110/6b4ee5f1/attachment.html>


More information about the Kde-buildsystem mailing list