Review Request 122359: Create an uninstall target by default in KDE projects.
Aleix Pol Gonzalez
aleixpol at kde.org
Wed Feb 4 17:03:56 UTC 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122359/#review75428
-----------------------------------------------------------
Ship it!
kde-modules/KDECMakeSettings.cmake
<https://git.reviewboard.kde.org/r/122359/#comment52173>
maybe you want to add an option() call so it appears on ccmake as ON/OFF?
modules/ecm_uninstall.cmake.in
<https://git.reviewboard.kde.org/r/122359/#comment52174>
+1
- Aleix Pol Gonzalez
On Feb. 3, 2015, 9:19 p.m., Alex Merry wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122359/
> -----------------------------------------------------------
>
> (Updated Feb. 3, 2015, 9:19 p.m.)
>
>
> Review request for Build System, Extra Cmake Modules and KDE Frameworks.
>
>
> Repository: extra-cmake-modules
>
>
> Description
> -------
>
> Add a module to provide an uninstall target.
>
> This is basically just the code available on the CMake FAQ item about
> `make uninstall`, but packaged up in a convenient module.
>
> Create an uninstall target by default in KDE projects.
>
>
> Diffs
> -----
>
> docs/module/ECMUninstallTarget.rst PRE-CREATION
> kde-modules/KDECMakeSettings.cmake 4ccbf82eaf54d6777a8c2296aea4b77e0d1292cb
> modules/ECMUninstallTarget.cmake PRE-CREATION
> modules/ecm_uninstall.cmake.in PRE-CREATION
>
> Diff: https://git.reviewboard.kde.org/r/122359/diff/
>
>
> Testing
> -------
>
> Checked with KCoreAddons.
>
>
> Thanks,
>
> Alex Merry
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-buildsystem/attachments/20150204/373d85b6/attachment.html>
More information about the Kde-buildsystem
mailing list