Review Request 122359: Create an uninstall target by default in KDE projects.

[Kevin Funk]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122359/#review75342
-----------------------------------------------------------

Ship it!


Looks good to me, but I'll wait for some others giving their +1, too


modules/ecm_uninstall.cmake.in
<https://git.reviewboard.kde.org/r/122359/#comment52112>

    I'd remove the text inside the condition of `elseif`, `endif` and `endforeach` (I know it is copied code, but still ...)


- Kevin Funk


On Feb. 3, 2015, 8:19 p.m., Alex Merry wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122359/
> -----------------------------------------------------------
> 
> (Updated Feb. 3, 2015, 8:19 p.m.)
> 
> 
> Review request for Build System, Extra Cmake Modules and KDE Frameworks.
> 
> 
> Repository: extra-cmake-modules
> 
> 
> Description
> -------
> 
> Add a module to provide an uninstall target.
> 
> This is basically just the code available on the CMake FAQ item about
> `make uninstall`, but packaged up in a convenient module.
> 
> Create an uninstall target by default in KDE projects.
> 
> 
> Diffs
> -----
> 
>   docs/module/ECMUninstallTarget.rst PRE-CREATION 
>   kde-modules/KDECMakeSettings.cmake 4ccbf82eaf54d6777a8c2296aea4b77e0d1292cb 
>   modules/ECMUninstallTarget.cmake PRE-CREATION 
>   modules/ecm_uninstall.cmake.in PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/122359/diff/
> 
> 
> Testing
> -------
> 
> Checked with KCoreAddons.
> 
> 
> Thanks,
> 
> Alex Merry
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-buildsystem/attachments/20150203/49b657af/attachment-0001.html>