Review Request 126303: ECMAddAppIconMacro: Add OUTFILE parameter

[Alex Merry]

> On Dec. 12, 2015, 3:39 p.m., Alex Merry wrote:
> >

I'm not going to make you write a unit test for this, since this module didn't have any to begin with, but if you *were* willing to write tests, I would be very grateful.


- Alex


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126303/#review89390
-----------------------------------------------------------


On Dec. 10, 2015, 8:25 p.m., Dominik Schmidt wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126303/
> -----------------------------------------------------------
> 
> (Updated Dec. 10, 2015, 8:25 p.m.)
> 
> 
> Review request for Extra Cmake Modules.
> 
> 
> Repository: extra-cmake-modules
> 
> 
> Description
> -------
> 
> On OSX I want to ship "Tomahawk.icns" instead of "tomahawkSources.icns" which is the autogenerated name for our sources variable, thus I added an optional paramater allowing to override the basename (without extension).
> 
> 
> Diffs
> -----
> 
>   modules/ECMAddAppIcon.cmake f90d4c3 
> 
> Diff: https://git.reviewboard.kde.org/r/126303/diff/
> 
> 
> Testing
> -------
> 
> Tested it in Tomahawk and it works.
> 
> edit1: Actually, something is fishy. Still investigating.
> edit2: Nope, everything's fine. Random CMake fnord, hadn't tried a clean build.
> 
> 
> Thanks,
> 
> Dominik Schmidt
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-buildsystem/attachments/20151212/fd0bc07f/attachment-0001.html>