Review Request 126303: ECMAddAppIconMacro: Add OUTFILE parameter

[Alex Merry]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126303/#review89390
-----------------------------------------------------------



modules/ECMAddAppIcon.cmake (line 11)
<https://git.reviewboard.kde.org/r/126303/#comment61151>

    Documen the parameter, please (especially the fact that it should be a filename, not a path, without an extension).


- Alex Merry


On Dec. 10, 2015, 8:25 p.m., Dominik Schmidt wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126303/
> -----------------------------------------------------------
> 
> (Updated Dec. 10, 2015, 8:25 p.m.)
> 
> 
> Review request for Extra Cmake Modules.
> 
> 
> Repository: extra-cmake-modules
> 
> 
> Description
> -------
> 
> On OSX I want to ship "Tomahawk.icns" instead of "tomahawkSources.icns" which is the autogenerated name for our sources variable, thus I added an optional paramater allowing to override the basename (without extension).
> 
> 
> Diffs
> -----
> 
>   modules/ECMAddAppIcon.cmake f90d4c3 
> 
> Diff: https://git.reviewboard.kde.org/r/126303/diff/
> 
> 
> Testing
> -------
> 
> Tested it in Tomahawk and it works.
> 
> edit1: Actually, something is fishy. Still investigating.
> edit2: Nope, everything's fine. Random CMake fnord, hadn't tried a clean build.
> 
> 
> Thanks,
> 
> Dominik Schmidt
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-buildsystem/attachments/20151212/cc67409d/attachment.html>