Review Request 123470: Port remaining find modules to ecm_find_package_version_check.

Alex Merry alex.merry at kde.org
Fri Apr 24 09:19:04 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123470/#review79430
-----------------------------------------------------------


You need to do

    include(${CMAKE_CURRENT_LIST_DIR}/ECMFindModuleHelpersStub.cmake)

before you can safely use ecm_find_package_version_check.

- Alex Merry


On April 22, 2015, 6:23 p.m., Michael Palimaka wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123470/
> -----------------------------------------------------------
> 
> (Updated April 22, 2015, 6:23 p.m.)
> 
> 
> Review request for Extra Cmake Modules.
> 
> 
> Repository: extra-cmake-modules
> 
> 
> Description
> -------
> 
> Port remaining find modules to ecm_find_package_version_check.
> 
> 
> Diffs
> -----
> 
>   find-modules/FindEGL.cmake 7247437196555ac8139423233faf4e73a21458cd 
>   find-modules/FindKF5.cmake 30b20948063f7fc3b528e01293202dfcd443567b 
>   find-modules/FindLibGit2.cmake 22fc5ebb222ffe8c0b4a73dea9905da71ba5c0a8 
>   find-modules/FindOpenEXR.cmake b63b8cd02ca2f906c997114e8dd9113be89497f9 
>   find-modules/FindSharedMimeInfo.cmake ebbe32844925f94927d4561d12b0a8782293d390 
>   find-modules/FindX11_XCB.cmake 8b975e6a8731553f07fae8de94fcdf19f2fddbf5 
> 
> Diff: https://git.reviewboard.kde.org/r/123470/diff/
> 
> 
> Testing
> -------
> 
> Tests pass.
> 
> 
> Thanks,
> 
> Michael Palimaka
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-buildsystem/attachments/20150424/258245ee/attachment.html>


More information about the Kde-buildsystem mailing list