<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/123470/">https://git.reviewboard.kde.org/r/123470/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">You need to do</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;"><div class="codehilite" style="background: #f8f8f8"><pre style="line-height: 125%">include(<span style="color: #BC7A00">${</span>CMAKE_CURRENT_LIST_DIR<span style="color: #BC7A00">}</span>/ECMFindModuleHelpersStub.cmake)
</pre></div>
</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">before you can safely use ecm_find_package_version_check.</p></pre>
<br />
<p>- Alex Merry</p>
<br />
<p>On April 22nd, 2015, 6:23 p.m. UTC, Michael Palimaka wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Extra Cmake Modules.</div>
<div>By Michael Palimaka.</div>
<p style="color: grey;"><i>Updated April 22, 2015, 6:23 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
extra-cmake-modules
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Port remaining find modules to ecm_find_package_version_check.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Tests pass.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>find-modules/FindEGL.cmake <span style="color: grey">(7247437196555ac8139423233faf4e73a21458cd)</span></li>
<li>find-modules/FindKF5.cmake <span style="color: grey">(30b20948063f7fc3b528e01293202dfcd443567b)</span></li>
<li>find-modules/FindLibGit2.cmake <span style="color: grey">(22fc5ebb222ffe8c0b4a73dea9905da71ba5c0a8)</span></li>
<li>find-modules/FindOpenEXR.cmake <span style="color: grey">(b63b8cd02ca2f906c997114e8dd9113be89497f9)</span></li>
<li>find-modules/FindSharedMimeInfo.cmake <span style="color: grey">(ebbe32844925f94927d4561d12b0a8782293d390)</span></li>
<li>find-modules/FindX11_XCB.cmake <span style="color: grey">(8b975e6a8731553f07fae8de94fcdf19f2fddbf5)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/123470/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>