Review Request 120428: Build system: fix disabling of plugins according to missing deps

[Nicolás Alvarez]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120428/
-----------------------------------------------------------

(Updated Sept. 30, 2014, 12:42 p.m.)


Status
------

This change has been marked as submitted.


Review request for Build System and Kate.


Repository: kate


Description
-------

Apparently setting BUILD_foo to OFF from CMakeLists.txt is not enough to disable an ecm_optional_add_subdirectory. Instead, I'm now not running the ecm_optional_add_subdirectory at all if the deps aren't found.


Diffs
-----

  addons/CMakeLists.txt 1c3e8ff 

Diff: https://git.reviewboard.kde.org/r/120428/diff/


Testing
-------

Tested on Windows, without KF5Plasma. The sessionapplet plugin was correctly skipped.


Thanks,

Nicolás Alvarez

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-buildsystem/attachments/20140930/c3e46dd5/attachment.html>