Review Request 120428: Build system: fix disabling of plugins according to missing deps

[Michal Humpula]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120428/#review67654
-----------------------------------------------------------

Ship it!


Yeah, I've notice the same problem with yesterday clean rebuild. It's ugly as hell, but probably the only reasonable solution.

- Michal Humpula


On Zář. 29, 2014, 9:50 odp., Nicolás Alvarez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120428/
> -----------------------------------------------------------
> 
> (Updated Zář. 29, 2014, 9:50 odp.)
> 
> 
> Review request for Build System and Kate.
> 
> 
> Repository: kate
> 
> 
> Description
> -------
> 
> Apparently setting BUILD_foo to OFF from CMakeLists.txt is not enough to disable an ecm_optional_add_subdirectory. Instead, I'm now not running the ecm_optional_add_subdirectory at all if the deps aren't found.
> 
> 
> Diffs
> -----
> 
>   addons/CMakeLists.txt 1c3e8ff 
> 
> Diff: https://git.reviewboard.kde.org/r/120428/diff/
> 
> 
> Testing
> -------
> 
> Tested on Windows, without KF5Plasma. The sessionapplet plugin was correctly skipped.
> 
> 
> Thanks,
> 
> Nicolás Alvarez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-buildsystem/attachments/20140930/326d2979/attachment.html>