Review Request 116639: Do not read LOCATION property of desktoptojson

Aurélien Gâteau agateau at kde.org
Mon Mar 10 10:27:17 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116639/
-----------------------------------------------------------

(Updated March 10, 2014, 10:27 a.m.)


Status
------

This change has been marked as submitted.


Review request for Build System and KDE Frameworks.


Repository: kservice


Description
-------

This makes the code CMP0026 compliant. Surprisingly I never saw the CMake warning about this policy. Don't know why.


Diffs
-----

  KF5ServiceMacros.cmake f70a185 

Diff: https://git.reviewboard.kde.org/r/116639/diff/


Testing
-------

Tested with kservice/tests/kservicetojsontest, using both the old and the new syntax. Rebuilt kde-workspace.


Thanks,

Aurélien Gâteau

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-buildsystem/attachments/20140310/7e81fe4b/attachment.html>


More information about the Kde-buildsystem mailing list