Review Request 116646: Improve FindWayland.cmake
Alex Merry
alex.merry at kde.org
Fri Mar 7 00:15:53 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116646/
-----------------------------------------------------------
Review request for Build System, Extra Cmake Modules and KDE Frameworks.
Repository: extra-cmake-modules
Description
-------
Improve FindWayland.cmake
- Use Wayland_VERSION instead of Wayland_VERSION_STRING
- Put pkg-config calls within the helper macro
- Extract the version from wayland-version.h if necessary
- Add the dependency of wayland-egl on wayland-client
- Improve documentation
Diffs
-----
find-modules/FindWayland.cmake a121de9f8adda1e035b0f8e8401be26a45b61af4
Diff: https://git.reviewboard.kde.org/r/116646/diff/
Testing
-------
Created a test CMakeLists.txt to call this, and played with various arguments to COMPONENTS and OPTIONAL_COMPONENTS, including when include files for certain components were removed from the system (so those components would not be found). Everything worked as expected.
Thanks,
Alex Merry
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-buildsystem/attachments/20140307/cddefd7f/attachment.html>
More information about the Kde-buildsystem
mailing list