Review Request 116653: Create ECMFindModuleHelpers module for common find-module code

Alex Merry alex.merry at kde.org
Sat Mar 8 16:13:48 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116653/
-----------------------------------------------------------

(Updated March 8, 2014, 4:13 p.m.)


Review request for Build System, Extra Cmake Modules and KDE Frameworks.


Changes
-------

Split the component-handling macros into two logical parts, so that one can be used without the other.

Also properly namespaced variables, since these are macros rather than functions (for good reason).


Summary (updated)
-----------------

Create ECMFindModuleHelpers module for common find-module code


Repository: extra-cmake-modules


Description (updated)
-------

Create ECMFindModuleHelpers module for common find-module code

This currently mostly contains macros for handling components;
FindWayland and FindXCB are ported to use this module, which comes with
various improvements for them.


Diffs (updated)
-----

  find-modules/FindWayland.cmake a121de9f8adda1e035b0f8e8401be26a45b61af4 
  find-modules/FindXCB.cmake eb3075885bc408fc4c213516a387dfcd0e75cb8b 
  modules/ECMFindModuleHelpers.cmake PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/116653/diff/


Testing
-------

Tested various configurations with a test CMakeLists.txt file, including with various include files missing.

Configured and built kwindowsystem and kde-workspace.


Thanks,

Alex Merry

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-buildsystem/attachments/20140308/3de1ad04/attachment.html>


More information about the Kde-buildsystem mailing list