Review Request 116653: Factor out common code for component-based find modules

Alex Merry alex.merry at
Fri Mar 7 20:04:16 UTC 2014

This is an automatically generated e-mail. To reply, visit:

Review request for Build System, Extra Cmake Modules and KDE Frameworks.

Repository: extra-cmake-modules


Factor out common code for component-based find modules

This comes with improvements for FindWayland and FindXCB:
- <module>_VERSION instead of <module>_VERSION_STRING
- set <module>_LIBRARIES to contain targets, so that
  <module>_INCLUDE_DIRS and <module>_DEFINITIONS are unnecessary
- do pkg-config calls per-component
- handle inter-component dependencies
- improve documentation (in CMake 3.0 style)
- improve license texts (following CMake's style)

In FindWayland:
- extract the version from wayland-version.h if necessary


  find-modules/FindWayland.cmake a121de9f8adda1e035b0f8e8401be26a45b61af4 
  find-modules/FindXCB.cmake eb3075885bc408fc4c213516a387dfcd0e75cb8b 
  modules/ECMFindModuleHelpers.cmake PRE-CREATION 



Tested various configurations with a test CMakeLists.txt file, including with various include files missing.

Configured and built kwindowsystem and kde-workspace.


Alex Merry

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <>

More information about the Kde-buildsystem mailing list