Review Request 119263: misc: Do not call remove_tree with `safe' set to 1.

[Michael Pyne]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119263/#review62263
-----------------------------------------------------------

Ship it!


Good idea. I think I've run across this before too, so I'm glad you located the cause. Reviewing the File::Path module documentation implies that this "safe" option is more about not accidentally giving more permissive permissions to files during the delete process. There should be no information leak concerns with files in the build directory so I didn't need to use this option in the first place.

- Michael Pyne


On July 13, 2014, 3:44 p.m., Raphael Kubo da Costa wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119263/
> -----------------------------------------------------------
> 
> (Updated July 13, 2014, 3:44 p.m.)
> 
> 
> Review request for Build System, kdesrc-build and Michael Pyne.
> 
> 
> Repository: kdesrc-build
> 
> 
> Description
> -------
> 
> This makes kdesrc-build fail to clean the build directories if there are
> files without write permissions -- this happens if a CMake version with
> automoc support is used, as AutomocInfo.cmake (aka AutogenInfo.cmake) is
> written with the permissions of CMake's Auto{gen,moc}Info.cmake.in,
> which can be 0444 in some systems.
> 
> 
> Diffs
> -----
> 
>   kdesrc-build 1932e20962a4a3c226f25128cb9c420e95a5abd6 
> 
> Diff: https://git.reviewboard.kde.org/r/119263/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Raphael Kubo da Costa
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-buildsystem/attachments/20140714/c9550794/attachment.html>