<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/119263/">https://git.reviewboard.kde.org/r/119263/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Good idea. I think I've run across this before too, so I'm glad you located the cause. Reviewing the File::Path module documentation implies that this "safe" option is more about not accidentally giving more permissive permissions to files during the delete process. There should be no information leak concerns with files in the build directory so I didn't need to use this option in the first place.</p></pre>
<br />
<p>- Michael Pyne</p>
<br />
<p>On July 13th, 2014, 3:44 p.m. UTC, Raphael Kubo da Costa wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Build System, kdesrc-build and Michael Pyne.</div>
<div>By Raphael Kubo da Costa.</div>
<p style="color: grey;"><i>Updated July 13, 2014, 3:44 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdesrc-build
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This makes kdesrc-build fail to clean the build directories if there are
files without write permissions -- this happens if a CMake version with
automoc support is used, as AutomocInfo.cmake (aka AutogenInfo.cmake) is
written with the permissions of CMake's Auto{gen,moc}Info.cmake.in,
which can be 0444 in some systems.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kdesrc-build <span style="color: grey">(1932e20962a4a3c226f25128cb9c420e95a5abd6)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/119263/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>