Deprecating ECMDBusAddActivationService

Albert Astals Cid aacid at kde.org
Wed Apr 16 21:37:51 UTC 2014


El Dimecres, 16 d'abril de 2014, a les 10:58:43, Alex Merry va escriure:
> I realise there hasn't even been a single release yet, but I'd already
> like to deprecate the ecm_dbus_add_activation_service macro; uses of it
> can be replaced by
> 
> configure_file(${CMAKE_CURRENT_SOURCE_DIR}/foo.service.in
> ${CMAKE_CURRENT_BINARY_DIR}/foo.service)
> install(FILES ${CMAKE_CURRENT_BINARY_DIR}/foo.service DESTINATION
> ${DBUS_SERVICES_INSTALL_DIR})
> 
> for each service you want to install, which is a lot less magic.  It
> only really simplifies things for projects that want to install a lot of
> service files at once (I can't find any).
> 
> Given there are only two users according to LXR, I would be inclined to
> remove it entirely, except that we've already released beta1 and so I
> want to maintain source compatibility.
> 
> Any objections to this?

Personally, just kill it, it's used in two places and was part of a beta of 
something i doubt much people besides us is using.

Let's not drag this for years without any real need.

Cheers,
  Albert

> 
> Alex
> 
> 
> PS: I also really don't like ECMInstallIcons, which is far too
> KDE-specific, but I'm still figuring out the best thing to do with that.
> _______________________________________________
> Kde-buildsystem mailing list
> Kde-buildsystem at kde.org
> https://mail.kde.org/mailman/listinfo/kde-buildsystem



More information about the Kde-buildsystem mailing list