Review Request 112448: FindSamba add PkgConfig fallback
Christophe Giboudeaux
cgiboudeaux at gmx.com
Mon Sep 9 19:44:48 UTC 2013
On Monday 09 September 2013 21:37:37 Stephen Kelly wrote:
> Stephen Kelly wrote:
> > Christophe Giboudeaux wrote:
> >> find_library(SAMBA_LIBRARIES NAMES smbclient HINTS ${PC_SAMBA_LIBDIR})
> >
> > This should be _LIBRARY, not _LIBRARIES. Followed by:
> > set(SAMBA_LIBRARIES ${SAMBA_LIBRARY})
>
> The patch was committed, but this problem was not fixed.
>
On purpose, the fix went into 4.11 and master.
I don't see the need to introduce _LIBRARY in these branches.
More information about the Kde-buildsystem
mailing list