Review Request 112448: FindSamba add PkgConfig fallback

Stephen Kelly steveire at gmail.com
Mon Sep 9 19:37:37 UTC 2013


Stephen Kelly wrote:

> Christophe Giboudeaux wrote:
> 
>> find_library(SAMBA_LIBRARIES NAMES smbclient HINTS ${PC_SAMBA_LIBDIR})
>> 
> 
> This should be _LIBRARY, not _LIBRARIES. Followed by:
> 
>  set(SAMBA_LIBRARIES ${SAMBA_LIBRARY})
> 

The patch was committed, but this problem was not fixed.

Thanks,

Steve.




More information about the Kde-buildsystem mailing list