Review Request 112451: Adapt the DocBook finders to newer naming conventions

[Alexander Neundorf]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112451/#review39371
-----------------------------------------------------------


Did you verify that these files work as expected ?

AFAIK, find_package_handle_standard_args() sets by default the UPPERCASE_FOUND variable, not the CamelCase_FOUND variable.
To have it set CamelCase_FOUND, i.e. DocBookXML_FOUND (instead of DOCBOOKXML_FOUND), use the new signature:
find_package_handle_standard_args(FOUND_VAR DocBookXML_FOUND
                                  REQUIRED_VARS DocBookXSL_DIR )

After that you can set the old UPPERCASE variables for compatibility if you want to.


- Alexander Neundorf


On Sept. 4, 2013, 2:50 p.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112451/
> -----------------------------------------------------------
> 
> (Updated Sept. 4, 2013, 2:50 p.m.)
> 
> 
> Review request for Build System, KDE Frameworks and Luigi Toscano.
> 
> 
> Description
> -------
> 
> When trying to properly split KDocTools I saw that FindDocBookXML.cmake and FindDocBookXSL.cmake were at an attic directory that was not being processed.
> 
> This patch changes them to have them usable for KF5.
> 
> 
> Diffs
> -----
> 
>   attic/modules/FindDocBookXML.cmake  
>   attic/modules/FindDocBookXSL.cmake  
> 
> Diff: http://git.reviewboard.kde.org/r/112451/diff/
> 
> 
> Testing
> -------
> 
> Installs and seems to work.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-buildsystem/attachments/20130904/225cb81f/attachment.html>