<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/112451/">http://git.reviewboard.kde.org/r/112451/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Did you verify that these files work as expected ?
AFAIK, find_package_handle_standard_args() sets by default the UPPERCASE_FOUND variable, not the CamelCase_FOUND variable.
To have it set CamelCase_FOUND, i.e. DocBookXML_FOUND (instead of DOCBOOKXML_FOUND), use the new signature:
find_package_handle_standard_args(FOUND_VAR DocBookXML_FOUND
REQUIRED_VARS DocBookXSL_DIR )
After that you can set the old UPPERCASE variables for compatibility if you want to.
</pre>
<br />
<p>- Alexander</p>
<br />
<p>On September 4th, 2013, 2:50 p.m. UTC, Aleix Pol Gonzalez wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Build System, KDE Frameworks and Luigi Toscano.</div>
<div>By Aleix Pol Gonzalez.</div>
<p style="color: grey;"><i>Updated Sept. 4, 2013, 2:50 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">When trying to properly split KDocTools I saw that FindDocBookXML.cmake and FindDocBookXSL.cmake were at an attic directory that was not being processed.
This patch changes them to have them usable for KF5.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Installs and seems to work.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>attic/modules/FindDocBookXML.cmake <span style="color: grey">()</span></li>
<li>attic/modules/FindDocBookXSL.cmake <span style="color: grey">()</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/112451/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>