Review Request 112451: Actually install the modules in the ecm attic

Aleix Pol Gonzalez aleixpol at kde.org
Tue Sep 3 12:45:52 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112451/
-----------------------------------------------------------

(Updated Sept. 3, 2013, 12:45 p.m.)


Review request for Build System, KDE Frameworks and Luigi Toscano.


Changes
-------

Move DocBookXML and DocBookXSL to ecm/find-modules.


Description
-------

When trying to properly split KDocTools I saw that FindDocBookXML.cmake and FindDocBookXSL.cmake were at an attic directory that was not being processed.

This patch adds the directory to be used and fixes the installation so it works. It looks weird to me that this was not the case and maybe I'm missing something. Please tell me if that's the case.


Diffs (updated)
-----

  attic/modules/FindDocBookXML.cmake  
  attic/modules/FindDocBookXSL.cmake  

Diff: http://git.reviewboard.kde.org/r/112451/diff/


Testing
-------

Installs and seems to work.


Thanks,

Aleix Pol Gonzalez

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-buildsystem/attachments/20130903/c364edce/attachment.html>


More information about the Kde-buildsystem mailing list