Review Request 112451: Actually install the modules in the ecm attic

[Alexander Neundorf]

> On Sept. 2, 2013, 3:46 p.m., David Faure wrote:
> > I'm pretty sure this is wrong.
> > 
> > Attic == to be sorted out.
> > 
> > If these two find modules are needed, extract them, clean them up (ensure they pass modern standards, whatever that is exactly for cmake modules, I assume that's documented somewhere in the wiki), move them to the proper location (cmake, proper ECM subdir, or near the rare app code that needs it).
> > 
> > Don't install the whole of attic in one go, it defeats its purpose (to extract what we need one by one and throw out the rest).
> > 
> > For this particular case -- isn't kdoctools and its users the only place where this is used? So it could be installed by kdoctools itself, no? (assuming it's needed by the apps, otherwise it could even be made internal to kdoctools).
> 
> Aleix Pol Gonzalez wrote:
>     Well, if I understand it correctly, the plan is to have all the finders in ECM by default.
>     See http://community.kde.org/Frameworks/Epics/Splitting_kdelibs
>     
>     "All Find*.cmake modules needed by the framework and used also by other frameworks have been upstreamed to extra-cmake-modules (via the kde-buildsystem mailing list) or directly to cmake (via the cmake list). To make sure of this, do not append to CMAKE_MODULE_PATH, but set it."
>     
>     Either way, I didn't know the attic was for things that had to be polished... Why does it even have a CMakeLists.txt file then?
>

David is right.

The CMakeLists.txt is probably the one copied from kdelibs/cmake/modules/. It should be unused.


- Alexander


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112451/#review39177
-----------------------------------------------------------


On Sept. 2, 2013, 3:09 p.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112451/
> -----------------------------------------------------------
> 
> (Updated Sept. 2, 2013, 3:09 p.m.)
> 
> 
> Review request for Build System and KDE Frameworks.
> 
> 
> Description
> -------
> 
> When trying to properly split KDocTools I saw that FindDocBookXML.cmake and FindDocBookXSL.cmake were at an attic directory that was not being processed.
> 
> This patch adds the directory to be used and fixes the installation so it works. It looks weird to me that this was not the case and maybe I'm missing something. Please tell me if that's the case.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 5a22f85 
>   attic/modules/CMakeLists.txt c832bed 
> 
> Diff: http://git.reviewboard.kde.org/r/112451/diff/
> 
> 
> Testing
> -------
> 
> Installs and seems to work.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-buildsystem/attachments/20130902/8303013f/attachment.html>