Review Request 113406: Add a macro to automatically generate forward headers

Aleix Pol Gonzalez aleixpol at kde.org
Tue Oct 29 00:28:08 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113406/
-----------------------------------------------------------

(Updated Oct. 29, 2013, 12:28 a.m.)


Review request for Build System, KDE Frameworks and Stephen Kelly.


Changes
-------

updated patch following remarks, added KParts changes in a more stable place.


Repository: extra-cmake-modules


Description
-------

Create a macro that will generate the forward headers like we used to, in cmake configure time.

Here's an example of how we'd port KParts to that macro: http://paste.opensuse.org/9880051
After the change, these are the installed headers: http://paste.opensuse.org/90980400


Diffs (updated)
-----

  modules/ECMGenerateHeaders.cmake PRE-CREATION 

Diff: http://git.reviewboard.kde.org/r/113406/diff/


Testing
-------

Ported KParts and still everything works.


File Attachments (updated)
----------------

example of how KParts would change
  http://git.reviewboard.kde.org/media/uploaded/files/2013/10/29/43e2c958-9908-4249-9bb6-9395d91b5643__kf5-kparts-headers-test.patch


Thanks,

Aleix Pol Gonzalez

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-buildsystem/attachments/20131029/dc7c89b5/attachment.html>


More information about the Kde-buildsystem mailing list