Review Request 113406: Add a macro to automatically generate forward headers

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113406/#review42415
-----------------------------------------------------------


Thanks for working on this!


modules/ECMGenerateHeaders.cmake
<http://git.reviewboard.kde.org/r/113406/#comment30804>

    is used += to



modules/ECMGenerateHeaders.cmake
<http://git.reviewboard.kde.org/r/113406/#comment30805>

    This variable name isn't intuitive, there are headers everywhere (source, binary, install dir). Maybe call it SOURCE_DIR or HEADERS_SOURCE_DIR?


- David Faure


On Oct. 26, 2013, 10:56 a.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113406/
> -----------------------------------------------------------
> 
> (Updated Oct. 26, 2013, 10:56 a.m.)
> 
> 
> Review request for Build System, KDE Frameworks and Stephen Kelly.
> 
> 
> Repository: extra-cmake-modules
> 
> 
> Description
> -------
> 
> Create a macro that will generate the forward headers like we used to, in cmake configure time.
> 
> Here's an example of how we'd port KParts to that macro: http://paste.opensuse.org/9880051
> After the change, these are the installed headers: http://paste.opensuse.org/90980400
> 
> 
> Diffs
> -----
> 
>   modules/ECMGenerateHeaders.cmake PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/113406/diff/
> 
> 
> Testing
> -------
> 
> Ported KParts and still everything works.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-buildsystem/attachments/20131027/6a62025c/attachment.html>